"Invalid e-mail address" error - Unclassified NewsBoard

Saxtus

2009-02-24, 20:25 #1

Member since Jan 2007 · 84 posts · Location: Athens, Greece
Group memberships: Members

Show profile ·

Link to this post

Subject: "Invalid e-mail address" error

If a user try to register with (or change his/her) e-mail to one that has double underscores, like name__surname@domain.tpl, the e-mail address fails the validity test of UNB.

The Answer to Life, the Universe, and Everything = 42

Yves (Administrator) 2009-02-24, 20:31 #2

User title: UNB developer & webmaster
Member since Jan 2004 · 3855 posts · Location: Erlangen, Germany
Group memberships: Administrators, Members

Show profile ·

Link to this post

Problem located. It must be common.lib.php, function is_mailaddr. It looks like the regular expression doesn't allow more than one underscore (_) in a row. Do such e-mail addresses really exist? According to the RFC, it seems to be allowed. I must have missed that about 4 years ago...

As a quick fix, you could probably replace the similar looking line in that function with this:

$pattern_local = '^[A-Za-z0-9.!#$%&'*+\\-/=?\\^_`{|}~]+$';

♪ ...nanananah, all in all we’re just brilliant thieves, nanananah... ♪♬

Saxtus

2009-02-24, 20:43 #3

Member since Jan 2007 · 84 posts · Location: Athens, Greece
Group memberships: Members

Show profile ·

Link to this post

Yes and not from random provider either, was from M$ Hotmail.
I made the user to send email to my gmail account because I couldn't believe it and it appears that they exist.

Of course, thank you for your promptly response!

P.S. Code seems malformed.

The Answer to Life, the Universe, and Everything = 42

This post was edited on 2009-02-24, 20:48 by Saxtus.

Yves (Administrator) 2009-02-24, 21:35 #4

User title: UNB developer & webmaster
Member since Jan 2004 · 3855 posts · Location: Erlangen, Germany
Group memberships: Administrators, Members

Show profile ·

Link to this post

Saxtus, I'm notifying you here that I'm not going to manually confirm anything to your mailbox. Please do not use a mailbox that cannot receive e-mails or I may lock/remove your board account. Thank you.

My code was only an estimation, I didn't test it right now.

♪ ...nanananah, all in all we’re just brilliant thieves, nanananah... ♪♬

Saxtus

2009-02-24, 21:50 #5

Member since Jan 2007 · 84 posts · Location: Athens, Greece
Group memberships: Members

Show profile ·

Link to this post

Quote by Yves:
Saxtus, I'm notifying you here that I'm not going to manually confirm anything to your mailbox. Please do not use a mailbox that cannot receive e-mails or I may lock/remove your board account. Thank you.

That was another bug...
Somehow my (now current) e-mail address in my profile was unconfirmed (probably had it there before the 2008-08-04 patch) and I couldn't make system to resend me the confirmation e-mail until I was changing to a temporary one that probably gave error and then back to my correct/gravatar one that I validated myself.

I didn't want to cause trouble but I didn't knew what else to do...

The Answer to Life, the Universe, and Everything = 42

Yves (Administrator) 2009-03-02, 18:40 #6

User title: UNB developer & webmaster
Member since Jan 2004 · 3855 posts · Location: Erlangen, Germany
Group memberships: Administrators, Members

Show profile ·

Link to this post

E-mail validation fixed. I have now replaced that entire function with not-so-old code, researched the valid characters from Wikipedia articles (referring to the relevant RFCs).

♪ ...nanananah, all in all we’re just brilliant thieves, nanananah... ♪♬