Location map service: url double encoding (Last and previous devel)

Night Nord

2008-03-01, 19:13 #1

Member since Feb 2008 · 15 posts · Location: Russia, Saint-Petersburg
Group memberships: Members

Show profile ·

Link to this post

Subject: Location map service: url double encoding (Last and previous devel)

Bug into unb_lib/users.inc.php (lines 391-399) and unb_lib/cp.inc.php (lines 1742-1751)

if ($show_location)
{
$tpitem['location'] = '';
if (rc('location_link'))
$tpitem['location'] .= '<a href="' . UnbLink(str_replace('%s', urlencode($user->GetLocation()), rc('location_link')), null, true, /*sid*/ false, /*derefer*/ true) . '">';
$tpitem['location'] .= t2h($user->GetLocation());
if (rc('location_link'))
$tpitem['location'] .= '</a>';
}

exactly in UnbLink(... urlencode(...) ... ).

There also is suggestion to make http://maps.google.com/maps?q=%s as default value, because map24 badly handles most non-USA cities and abbreviations, and also have no translation to other languages.

This post was edited on 2008-03-01, 19:21 by Night Nord.

Yves (Administrator) 2008-03-02, 10:33 #2

User title: UNB developer & webmaster
Member since Jan 2004 · 3855 posts · Location: Erlangen, Germany
Group memberships: Administrators, Members

Show profile ·

Link to this post

Thank you. I haven't looked at the function for a long time. Works better now.

Yes, Google Maps is to prefer today. Again, this setting is quite old. I'll change that. Map24 used to be good in Germany, later also Europe (no idea whether it's been available somewhere else, too, then).

♪ ...nanananah, all in all we’re just brilliant thieves, nanananah... ♪♬

Night Nord

2008-03-02, 10:40 #3

Member since Feb 2008 · 15 posts · Location: Russia, Saint-Petersburg
Group memberships: Members

Show profile ·

Link to this post

Thank you.