Log viewer timezone - Unclassified NewsBoard

Keith 2009-03-26, 10:42 #46

User title: 漢字おたく
Member since Feb 2007 · 60 posts · Location: Japan
Group memberships: Members

Show profile ·

Link to this post

In reply to post ID 10234

Thank you for making this change. :-)

I've just uploaded the new changes 20080305-dev and checked the log viewer.
I'm very happy to see the log entries in the timezone that I have set the board for, which is the timezone that I am living in.

Keith 2009-03-27, 19:45 #47

User title: 漢字おたく
Member since Feb 2007 · 60 posts · Location: Japan
Group memberships: Members

Show profile ·

Link to this post

Subject: new bug?

Sorry to bug you.

It is 3/28 4:30 am JST in my timezone. My server is 3/27 1:30 pm in its timezone.
I go to the log viewer to look at the log for March 28 but nothing displays.
I checked my server via ftp and the log file exists. The log is there. It is ok.
Just the viewer for the log is not behaving properly.

Another thing, I use the viewer to see the 3/27 log but only entries after 10:00 or so are displaying even though I set the Time field to >0:00.
I checked the 3/27 log via ftp and there exists entries earlier than what shows in the viewer.

Yves (Administrator) 2009-03-27, 21:35 #48

User title: UNB developer & webmaster
Member since Jan 2004 · 3855 posts · Location: Erlangen, Germany
Group memberships: Administrators, Members

Show profile ·

Link to this post

The log entries from the past are not updated. What's on disk remains on disk as-is. Only newly added log entries are written with the new timezone offset. This may lead to a temporary gap or "overwriting" of log entries after the board update, depending on whether the new log timezone is + or - of the old one and how far.

The log viewer was not touched at all. It still takes your date input and uses it as the filename of the log file to open. No calculations in there. Maybe you have an inappropriate time filter set (or it was the default)?

♪ ...nanananah, all in all we’re just brilliant thieves, nanananah... ♪♬

Keith 2009-03-28, 06:46 #49

User title: 漢字おたく
Member since Feb 2007 · 60 posts · Location: Japan
Group memberships: Members

Show profile ·

Link to this post

Yves,

I guess the problem is that the time format >0:00 will show only entries after 10:00. I have to set the time to >00:00 to show all entries.

However, I did just now notice that the default time is inappropriate because it is now 2009-03-28 15:45 but the default in the viewer is setting the time to >22:45. :huh:

Yves (Administrator) 2009-03-28, 20:24 #50

User title: UNB developer & webmaster
Member since Jan 2004 · 3855 posts · Location: Erlangen, Germany
Group memberships: Administrators, Members

Show profile ·

Link to this post

Ah, the log viewer seems to use the system timezone for its filter defaults. This still needs to be converted the same way as log entries written. But it's only a cosmetic issue, you can always remove that filter or set it to something more appropriate in your board timezone.

♪ ...nanananah, all in all we’re just brilliant thieves, nanananah... ♪♬

jense 2009-03-29, 19:45 #51

Member since Nov 2006 · 327 posts · Location: Dortmund
Group memberships: Members

Show profile ·

Link to this post

I've attached an adapted version of my patch, which takes care of this issue, AFAICT. It displays any times in the present user's timezone and adjusts the filter time accordingly...

Note, that the time field needs to be interpreted if board and user time differ, so that the string matching is a little less general. However, that's more of a theoretical issue.

Alala, Alala, Gimme three wishes - CSS

The author has attached one file to this post:

patch-0-3-logviewer 3.3 kBytes
You have no permission to open this file.